Lee-W commented on code in PR #54903:
URL: https://github.com/apache/airflow/pull/54903#discussion_r2316068446


##########
airflow-core/tests/unit/api_fastapi/common/test_parameters.py:
##########
@@ -18,11 +18,72 @@
 from __future__ import annotations
 
 import re
+from typing import Annotated
 
 import pytest
-from fastapi import HTTPException
+from fastapi import Depends, FastAPI, HTTPException
 
-from airflow.api_fastapi.common.parameters import SortParam
+from airflow.api_fastapi.common.parameters import FilterParam, SortParam, 
filter_param_factory
+from airflow.models import DagRun, Log
+
+
+class TestFilterParam:
+    def test_filter_param_factory_description(self):
+        app = FastAPI()  # Create a FastAPI app to test OpenAPI generation
+        expected_descriptions = {
+            "dag_id": "Filter by DAG ID Description",

Review Comment:
   ```suggestion
               "dag_id": "Filter by Dag ID Description",
   ```
   
   Whehter to use Dag or dag is still under discussion, but definitely not DAG 
is confirmed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to