ashb commented on code in PR #54813:
URL: https://github.com/apache/airflow/pull/54813#discussion_r2321856179
##########
providers/alibaba/src/airflow/providers/alibaba/cloud/log/oss_task_handler.py:
##########
@@ -95,6 +95,9 @@ def read(self, relative_path, ti: RuntimeTI) ->
tuple[LogSourceInfo, LogMessages
return messages, logs
return messages, None
+ def stream(self, relative_path: str, ti: RuntimeTI) -> LogResponse:
+ raise NotImplementedError
Review Comment:
Given we now do `getattr(remote_io, "stream")` we don't want this method
here anymore do we, as we don't want this to be called (else it would raise
NotImplementedError at runtime instead of falling back to the read method)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
