jscheffl commented on code in PR #54994:
URL: https://github.com/apache/airflow/pull/54994#discussion_r2322565813
##########
providers/edge3/src/airflow/providers/edge3/plugins/www/src/pages/JobsPage.tsx:
##########
@@ -22,12 +22,17 @@ import { useUiServiceJobs } from "openapi/queries";
import { ErrorAlert } from "src/components/ErrorAlert";
export const JobsPage = () => {
- const { data, error } = useUiServiceJobs();
+ // Note: might use this in future but core-ui-API is not yet bound:
+ // const autoRefreshInterval = useConfig("auto_refresh_interval") as number
| undefined;
Review Comment:
> The path forward would be to acknowledge that some users might need
get_config endpoint, and figure out a way to expose it publicly. (make it
stable, and move it from UI to public API). So plugins and users can depend on
it.
... which might also be a bit "strange" as we block displaying config per
default in UI but via (non stable/public) /ui API you get the same?
Anyway nothing that I see needs to hurry and go into 3.1, we can also fix
later as we have more urgent pressure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
