RoyLee1224 commented on code in PR #53981:
URL: https://github.com/apache/airflow/pull/53981#discussion_r2323581289
##########
airflow-core/src/airflow/ui/src/pages/Dag/Calendar/calendarUtils.ts:
##########
@@ -143,20 +143,26 @@ export const getCalendarCellColor = (
colorMode: CalendarColorMode = "total",
): string | { _dark: string; _light: string } => {
if (runs.length === 0) {
- return { _dark: "gray.700", _light: "gray.100" };
+ const colorScheme = colorMode === "total" ? TOTAL_COLOR_INTENSITIES :
FAILURE_COLOR_INTENSITIES;
+ return colorScheme[0];
}
const counts = calculateRunCounts(runs);
- if (counts.planned > 0) {
+ // Only show planned color if there are no actual runs (only planned)
+ if (counts.planned > 0 && counts.total === counts.planned) {
return PLANNED_COLOR;
}
- const targetCount = colorMode === "total" ? counts.total : counts.failed;
- const intensityLevel = getIntensityLevel(targetCount, colorMode);
- const colorScheme = colorMode === "total" ? TOTAL_COLOR_INTENSITIES :
FAILURE_COLOR_INTENSITIES;
+ // For failed runs mode, show failed runs
+ if (colorMode === "failed") {
+ const intensityLevel = getIntensityLevel(counts.failed, colorMode);
+ return FAILURE_COLOR_INTENSITIES[intensityLevel] ??
FAILURE_COLOR_INTENSITIES[0];
+ }
- return colorScheme[intensityLevel] ?? { _dark: "gray.700", _light:
"gray.100" };
+ // For total runs mode, show total runs in blue
Review Comment:
Not sure if we want to use blue color for total run calendar cells. I'm
personally fine with this choice, but I wanted to bring it up to make sure
we're all aligned on the color scheme.
cc @bbovenzi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
