ashb commented on code in PR #55259:
URL: https://github.com/apache/airflow/pull/55259#discussion_r2325057166
##########
providers/openlineage/src/airflow/providers/openlineage/utils/utils.py:
##########
@@ -52,7 +52,10 @@
is_dag_lineage_enabled,
is_task_lineage_enabled,
)
-from airflow.providers.openlineage.version_compat import AIRFLOW_V_3_0_PLUS,
get_base_airflow_version_tuple
+from airflow.providers.openlineage.version_compat import (
+ AIRFLOW_V_3_0_PLUS,
+ get_base_airflow_version_tuple,
+)
Review Comment:
Nit: unnecessary formatting change.
##########
providers/openlineage/src/airflow/providers/openlineage/utils/utils.py:
##########
@@ -842,8 +844,19 @@ def from_masker(cls, other: SecretsMasker) ->
OpenLineageRedactor:
instance = cls()
instance.patterns = other.patterns
instance.replacer = other.replacer
+ for attr in ["sensitive_variables_fields", "min_length_to_mask",
"secret_mask_adapter"]:
+ if hasattr(other, attr):
+ setattr(instance, attr, getattr(other, attr))
return instance
+ def _should_hide_value_for_key(self, name):
+ """Compatibility helper for should_hide_value_for_key across Airflow
versions."""
+ try:
+ return self.should_hide_value_for_key(name)
+ except AttributeError:
+ # fallback to module level function
+ return should_hide_value_for_key(name)
Review Comment:
I don't see this being imported anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
