vincbeck commented on code in PR #55506:
URL: https://github.com/apache/airflow/pull/55506#discussion_r2342216855
##########
providers/keycloak/src/airflow/providers/keycloak/auth_manager/keycloak_auth_manager.py:
##########
@@ -366,3 +374,17 @@ def _get_headers(access_token):
"Authorization": f"Bearer {access_token}",
"Content-Type": "application/x-www-form-urlencoded",
}
+
+ @staticmethod
+ def _token_expired(token: str) -> bool:
Review Comment:
That's what I did at first but then compat tests failed because this
function does not exist in Airflow 3.0.6 etc. So I moved it to Keycloak. We can
have it in `BaseAuthManager` but we also need it in `KeycloakAuthManager` for
older version of Airflow. For the long run I can copy paste this function in
`BaseAuthManager` without using it and when providers will have min Airflow
version >= 3.1, we'll be able to use it from `BaseAuthManager` and remove it
from Keycloak provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
