jscheffl commented on PR #55547: URL: https://github.com/apache/airflow/pull/55547#issuecomment-3283716115
> Nice! Functionality works! a few cleanup suggestions > > 1. When we request maintenance, we should probably not show up the "update maintenance comment" button until the worker enters maintenance mode. In the image below, it does not allow me to update comment when its still in maintenance request state > > 2. it would be cleaner if clicking on the "Update Comments" dialogue box actually closes the box. Currently you need to manually hit the close button Thanks for the feedback. (1) is actually a feature and was as far as I remember in the previous UI the same. But can double-check. (2) is a blocker for me, I am not sure why this happens but must be resolved prior merge. Funny it actually updates but does not close. It is the "same" code like in other dialogs but don't understand why it is different here :-D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
