dabla commented on PR #55094: URL: https://github.com/apache/airflow/pull/55094#issuecomment-3285062196
> > > @eladkal Do you prefer using asyncio.to_thread instead of sync_to_async from asgiref? > > > > > > I believe it's good - we are using sync_to_async in other places already. > > I am away from laptop so cant take a look at the code. > > As long as we are not forcing installing async packages to the users who use only sync approch that is good enough for me. Once providers are used in Airflow 3.1, they wont need the asgiref anymore as they would be able to use the async aget_connection method, thus the module is also only import if needed for fallback, otherwise it's not. As we have to keep providers backward compatible with Airflow 2, we need this fallback functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
