dabla commented on code in PR #55179:
URL: https://github.com/apache/airflow/pull/55179#discussion_r2344060719
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/msgraph.py:
##########
@@ -250,7 +250,9 @@ def to_msal_proxies(self, authority: str | None, proxies:
dict) -> dict | None:
def _build_request_adapter(self, connection) -> tuple[str, RequestAdapter]:
client_id = connection.login
client_secret = connection.password
- config = connection.extra_dejson if connection.extra else {}
+ # TODO: do not use connection.extra_dejson until it's fixed in Airflow
otherwise expect:
Review Comment:
Well the issue I linked to refered to the SyncToAsync issue we had with
MSGraphAsyncOperator, normally the issue was fixed in Airflow 3.0.4 and 3.0.5,
but once we started testing this previous fix we saw that the problem rose
again. This time it came from a different place, namely the
Connection.extra_dejson property. It seems there a change was made in 3.0.6
which calls the mask_secret method, which is the cause of the issue, as the
method expects to be run in an async context, but isn't the case here so it
throws the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
