ashb commented on code in PR #55589:
URL: https://github.com/apache/airflow/pull/55589#discussion_r2349212577
##########
airflow-core/src/airflow/models/serialized_dag.py:
##########
@@ -460,7 +460,9 @@ def write_dag(
@classmethod
def latest_item_select_object(cls, dag_id):
- return select(cls).where(cls.dag_id ==
dag_id).order_by(cls.created_at.desc()).limit(1)
+ # prevent "Out of sort memory" caused by large values in cls.data
column
+ latest_item_id = select(cls.id).where(cls.dag_id ==
dag_id).order_by(cls.created_at.desc()).limit(1)
+ return select(cls).where(cls.id == latest_item_id)
Review Comment:
Yeah readability is fine, my comment is about performance, and if this has a
negative (or it could be positive for all I know) impact on Postgres
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
