pierrejeambrun commented on code in PR #55257:
URL: https://github.com/apache/airflow/pull/55257#discussion_r2348840137
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py:
##########
@@ -87,6 +88,26 @@ def get_extra_links(
)
all_extra_links = {link_name: link_url or None for link_name, link_url in
sorted(all_extra_link_pairs)}
+ extra_link_records = (
+ session.query(XCom)
+ .filter(
+ XCom.dag_id == dag_id,
+ XCom.run_id == dag_run_id,
+ XCom.task_id == task_id,
+ XCom.map_index == map_index,
+ XCom.key.like("extra_link:%"),
+ )
+ .all()
Review Comment:
That could actually be another key that has nothing to do with links that
start with `extra_link` and we would mistaken it for a link.
Also having some parts of the `extra_links` fetched from DB tables through
xcom, and some other `operator_extra_links` coming from `get_extra_links` seems
weird. Not sure to have a better alternative in the current state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
