[
https://issues.apache.org/jira/browse/AIRFLOW-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974599#comment-16974599
]
ASF GitHub Bot commented on AIRFLOW-5926:
-----------------------------------------
mik-laj commented on pull request #6579: [AIRFLOW-5926] Fix race-condition in
TestCliWebServer
URL: https://github.com/apache/airflow/pull/6579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix race-condition in TestCliWebServer
> ---------------------------------------
>
> Key: AIRFLOW-5926
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5926
> Project: Apache Airflow
> Issue Type: Bug
> Components: cli
> Affects Versions: 1.10.6
> Reporter: Kamil Bregula
> Priority: Major
>
> The current tests work as follows.
> # The airflow command is started in a separate process, without waiting for
> it to finish. This separate process run the airflow process that creates the
> deamon process - airflow-webserver-monitor. The deamon process starts another
> process - gunicorn.
> # At the same time, the tests are waiting for the monitor process to start.
> Checks if the pid file for the monitor exists.
> # In the next step, the test checks that the airflow command has already
> ended
> *Bug* we should check the monitor process, not the command that starts it.
> # In the next step, the test checks if the gunicorn is already running
> # Tests sends a signal to the monitor to close processes - monitor and
> gunicorn.
> Summary:
> The test checks to see if there is a temporary process that starts the
> monitor instead of checking that the monitor is running.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
