ashb commented on code in PR #55712:
URL: https://github.com/apache/airflow/pull/55712#discussion_r2351571742
##########
airflow-core/src/airflow/settings.py:
##########
@@ -633,6 +633,21 @@ def prepare_syspath_for_config_and_plugins():
sys.path.append(PLUGINS_FOLDER)
+def __getattr__(name: str):
+ """Handle deprecated module attributes."""
+ if name == "MASK_SECRETS_IN_LOGS":
+ import warnings
+
+ warnings.warn(
+ "settings.MASK_SECRETS_IN_LOGS has been removed. "
+ "Use SecretsMasker.enable_log_masking(), disable_log_masking(), or
is_log_masking_enabled() instead.",
+ DeprecationWarning,
+ stacklevel=2,
+ )
+ return
Review Comment:
Returning None is intentional here? Won't that like cause equally weird
things? Or make things think secrets masking is disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
