sortega commented on code in PR #55517: URL: https://github.com/apache/airflow/pull/55517#discussion_r2343351850
########## airflow-core/tests/unit/utils/test_log_handlers.py: ########## @@ -79,7 +79,7 @@ ) from tests_common.test_utils.markers import skip_if_force_lowest_dependencies_marker -pytestmark = [pytest.mark.db_test, pytest.mark.xfail()] +pytestmark = [pytest.mark.db_test] Review Comment: pytest.mark.xfail makes a test "pass" when it fails (xfail stands for eXpected Fail). This was effectively ignoring all the tests in the file. Do you want me to remove the first commit of the pull request and keep it like that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
