ferruzzi commented on issue #55237:
URL: https://github.com/apache/airflow/issues/55237#issuecomment-3304905982

   Looking at it more, and after a chat with @ramitkataria  , we can see three 
approaches for JIRA, and option three is the clear winner:
   
   1. Wrapping the notifier in the `syc_to_async` method will block the 
Triggerer and will likely work but isn't ideal.  Let's leave that as a last 
resort.
   
   2. We could put in a PR to 
https://github.com/atlassian-api/atlassian-python-api/tree/master/atlassian to 
add async support.  That adds a dependency to their project which it's up to 
them to maintain, plus there will then be a wait for approval/merge/release/etc 
on their side, THEN a wait for Airflow to ingest that and bump our Jira minimum 
version so it's a LOOONG term answer which depends on them accepting and 
maintaining the work.  I think we should avoid this option, even if it's maybe 
the "right" answer, it's relying heavily on others.
   
   3. We can make a JiraAsyncHook which inherits HttpAsyncHook and has a 
[create_issue](https://github.com/atlassian-api/atlassian-python-api/blob/master/atlassian/jira.py#L1712)
 method to assemble the URL and call `post` using the aiohttp connection from 
HttpAsyncHook to make the call.  Looking at their code, most of what they are 
doing is building the URL and then calling request(POST) which we can replicate 
pretty easily with minimal code.
   
   I think Pagerduty looks like a similar solution should work too, but I 
haven't looked as closely there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to