jedcunningham commented on code in PR #55139:
URL: https://github.com/apache/airflow/pull/55139#discussion_r2360384951
##########
providers/fab/src/airflow/providers/fab/www/airflow_flask_app.py:
##########
@@ -21,7 +21,7 @@
from flask import Flask
if TYPE_CHECKING:
- from airflow.models.dagbag import DagBag
+ from airflow.models import DagBag
Review Comment:
Should this be DbDagBag in 3.1+ (or, whenever we land this)?
##########
providers/standard/src/airflow/providers/standard/sensors/external_task.py:
##########
@@ -51,6 +51,11 @@
if not AIRFLOW_V_3_0_PLUS:
from airflow.utils.session import NEW_SESSION, provide_session
+if AIRFLOW_V_3_1_PLUS:
+ from airflow.dag_processing.dagbag import DagBag
Review Comment:
Looking at what this does, we do not need to reparse the dag to check if the
task exists... that has a very real chance of not even working af3.
But, this is okay for now I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
