EvertonSA commented on issue #47950: URL: https://github.com/apache/airflow/issues/47950#issuecomment-3310816617
Let me explain before early conclusions are taken: for me, there is no point of checking if API Internals are available before calling the API. Lets say for example you are using google paid search. google search uses multiple internals to work (dns, auth, cache, etc etc). It is nonsense to test if the google search internals are available before calling the google search. Or imagine you are using a payment gateway configured with bank1 and bank2 and in your code you check the availability of bank1 and bank2 before calling the payment gateway. It seems like a claptrap. I have opened this issue with the intention of removing this check. I believe it is Microsoft ManagedIdentityCredential responsibility to deal with unhealthy metadata API, not Airflow, not us. Checking this metadata API does not add value and does not solve the problem as already vastly researched in classic TOCTOU bugs. I support encapsulation in this case by hiding implementation details behind a stable interface (ManagedIdentityCredential, backed by trillion dollar company Microsoft), making us, airflow users/developers merely consumers of a abstract interface instead of having to deal with internals. In addition, Microsoft is free to change it's internals. I can also bring dependency inversion principles, separation of concerns, and design patterns to this as well, but I'm no expert. If you need to report to the community if this is working or not, just triggering a simple databricks is sufficient. The effort and money spent trying to replicate this 429 depends on so many runs that will spend too much money from the company I work for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
