houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid 
unnecessary sleep to maintain local task job heart rate
URL: https://github.com/apache/airflow/pull/6553#discussion_r346974321
 
 

 ##########
 File path: airflow/jobs/base_job.py
 ##########
 @@ -171,17 +171,14 @@ def heartbeat(self):
             if self.state == State.SHUTDOWN:
                 self.kill()
 
-            is_unit_test = conf.getboolean('core', 'unit_test_mode')
 
 Review comment:
   I am thinking of patching sleep globally for all unit tests, so we won't 
have to worry about it going forward. is this the kind of change you all 
comfortable with?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to