jaketf commented on a change in pull request #6590: [AIRFLOW-5520] Add options 
to run Dataflow in a virtual environment
URL: https://github.com/apache/airflow/pull/6590#discussion_r346986819
 
 

 ##########
 File path: airflow/gcp/example_dags/example_dataflow.py
 ##########
 @@ -72,7 +72,11 @@
         options={
             'output': GCS_OUTPUT,
         },
-        check_if_running=CheckJobRunning.WaitForRun,
+        py_requirements=[
+            'apache-beam[gcp]'
 
 Review comment:
   nit: this example should either pin a beam version or specify minimum 
version of 2.14.0 where python3.6 3.7 support was added.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to