ashb commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026]
Add filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#discussion_r347020711
##########
File path: airflow/models/dag.py
##########
@@ -1384,7 +1390,8 @@ def sync_to_db(self, owner=None, sync_time=None,
session=None):
orm_dag.default_view = self._default_view
orm_dag.description = self.description
orm_dag.schedule_interval = self.schedule_interval
- session.merge(orm_dag)
+ orm_dag.tags = self.get_dagtags(session=session)
Review comment:
I wonder if it would be better to use a JSON column on the Dag table, rather
than needing a new dag-tag table.
SQLAlchemy has built in support for JSON columns for mysql, sqlite and
postgres, and with postgres we could even add an index on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
