pierrejeambrun commented on code in PR #55735:
URL: https://github.com/apache/airflow/pull/55735#discussion_r2376297803


##########
airflow-core/src/airflow/ui/src/constants/filterConfigs.tsx:
##########
@@ -61,6 +79,31 @@ export const useFilterConfigs = () => {
       label: translate("common:dagId"),
       type: FilterTypes.TEXT,
     },
+    [SearchParamsKeys.DAG_ID_PATTERN]: {
+      hotkeyDisabled: true,
+      icon: <DagIcon />,
+      label: translate("common:dagId"),
+      type: FilterTypes.TEXT,
+    },
+    [SearchParamsKeys.DAG_VERSION]: {
+      hotkeyDisabled: true,
+      icon: <MdHistory />,
+      label: translate("common:dagRun.dagVersions"),
+      min: 1,
+      type: FilterTypes.NUMBER,
+    },
+    [SearchParamsKeys.DURATION_GTE]: {
+      icon: <MdHourglassEmpty />,
+      label: translate("common:filters.durationFrom", "Duration From"), // To 
do: add translation key and remove default value

Review Comment:
   Did we miss these two 'todos' ?
   
   The PR is marked for `3.2.0`, this will not break translation freeze. You 
can go ahead and do that change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to