ashb opened a new pull request, #56079:
URL: https://github.com/apache/airflow/pull/56079
This change is a big one (too big if I'm honest, but I cannot for the life of
my think of a way of usefully separating this out) to the architecture of how
the Go-SDk works.
Previously the tasks ("the registry") and the executor would be compiled in
to
a single binary, and the go worker could only execute Tasks for a single DAG
version. Neither of these were good properties for production-ready code.
This changes the architecture as follows
```
┌──────────────────────┐ ┌───────────────────────────┐
│ airflow-go-worker │ │ DAG Bundle Plugin Binary │
│ │ │ │
│ ┌──────────────────┐ │ │ ┌─────────────────────┐ │
│ │ Celery Consumer │ │ │ │ Task Registry │ │
│ └────────┬─────────┘ │ │ └─────────┬───────────┘ │
│ │ │ │ │ │
│ ┌────────▼─────────┐ │ │ ┌─────────▼───────────┐ │
│ │ Plugin Client │◄┼─────┼─┤ Plugin Server │ │
│ └──────────────────┘ │ │ └─────────────────────┘ │
│ │ │ │
└──────────────────────┘ └───────────────────────────┘
```
The `airflow-go-worker` in this diagram is the Executor Worker -- i.e. it
gets
messages off a Celery queue and then hands off the Workload to another
process, communication to which is handled via Hashicorp's go-plugin.
Go-plugin is a well tested library used to implement both Terraform Providers
and Granfana plugins.
The package layout of this change is roughly as follows:
- `bundle/bundlev1/bundlev1server`
The server/bundle side of the plugin interface.
Contains the main entrypoint that bundles should call, `Serve()`
- `bundle/bundlev1`
The bundle-side types and interfaces. This is mostly what dag bundles will
import to register tasks:
```go
import "github.com/apache/airflow/go-sdk/bundle/bundlev1"
// ...
func (m *myBundle) RegisterDags(dagbag bundlev1.Registry) error {
tutorial_dag := bundle.AddDag("tutorial_dag")
tutorial_dag.AddTask(extract)
tutorial_dag.AddTask(transform)
tutorial_dag.AddTask(load)
}
```
- `internal/protov1`
The protobuf source and generated files, shared between clients and
servers.
- `pkg/bundles/shared`
Config and code shared between clients and servers that is
global/non-versioned/multi-version-aware.
- `pkg/bundles/bundleclientv1`
The client used to speak to v1 Bundle binaries.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
