jscheffl commented on code in PR #51792:
URL: https://github.com/apache/airflow/pull/51792#discussion_r2384008698
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -98,12 +98,17 @@ spec:
{{- if $containerLifecycleHooks }}
lifecycle: {{- tpl (toYaml $containerLifecycleHooks) . | nindent 12
}}
{{- end }}
- {{- if .Values.statsd.args }}
- args: {{ tpl (toYaml .Values.statsd.args) . | nindent 12 }}
- {{- else}}
args:
+ {{- if .Values.statsd.args }}
+ {{- range $arg := .Values.statsd.args }}
+ - {{ $arg | quote }}
+ {{- end }}
+ {{- else }}
- "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"
{{- end }}
+ - "--statsd.cache-size={{ .Values.statsd.cacheSize | default 1000
}}"
+ - "--statsd.cache-type={{ .Values.statsd.cacheType | default `lru`
}}"
+ - "--ttl={{ .Values.statsd.ttl }}"
Review Comment:
You can check the CI run in
https://github.com/apache/airflow/actions/runs/18055839919/job/51386419034?pr=51792
which shows the expected results after test and the result after changes. As
the default now is added by your change the test is failing because it does not
know about the new defaults:
<img width="1095" height="251" alt="image"
src="https://github.com/user-attachments/assets/3415615a-5b65-490a-8403-a4fafb584fa7";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
