RoyLee1224 commented on code in PR #56173:
URL: https://github.com/apache/airflow/pull/56173#discussion_r2395252734
##########
airflow-core/src/airflow/ui/src/components/FilterBar/filters/TextSearchFilter.tsx:
##########
@@ -56,7 +57,7 @@ export const TextSearchFilter = ({ filter, onChange, onRemove
}: FilterPluginPro
label={filter.config.label}
onChange={handleInputChange}
placeholder={filter.config.placeholder}
- value={String(filter.value ?? "")}
+ value={typeof filter.value === "string" ? filter.value : ""}
Review Comment:
@pierrejeambrun I think the string handling changes were necessary because
`FilterValue` now includes `DateRangeValue` objects. I'm getting TypeScript
ESLint errors without these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
