vincbeck commented on code in PR #56276: URL: https://github.com/apache/airflow/pull/56276#discussion_r2398841614
########## providers/amazon/src/airflow/providers/amazon/aws/hooks/firehose.py: ########## @@ -0,0 +1,56 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""This module contains AWS Firehose hook.""" + +from __future__ import annotations + +from collections.abc import Iterable + +from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook + + +class FirehoseHook(AwsBaseHook): + """ + Interact with Amazon Kinesis Firehose. + + Provide thick wrapper around :external+boto3:py:class:`boto3.client("firehose") <Firehose.Client>`. + + :param delivery_stream: Name of the delivery stream + + Additional arguments (such as ``aws_conn_id``) may be specified and + are passed down to the underlying AwsBaseHook. + + .. seealso:: + - :class:`airflow.providers.amazon.aws.hooks.base_aws.AwsBaseHook` + """ + + def __init__(self, delivery_stream: str, *args, **kwargs) -> None: + self.delivery_stream = delivery_stream + kwargs["client_type"] = "firehose" + super().__init__(*args, **kwargs) + + def put_records(self, records: Iterable) -> dict: + """ + Write batch records to Kinesis Firehose. + + .. seealso:: + - :external+boto3:py:meth:`Firehose.Client.put_record_batch` + + :param records: list of records + """ + return self.get_conn().put_record_batch(DeliveryStreamName=self.delivery_stream, Records=records) Review Comment: One comment that apply to your other hook as well. We try to avoid creating method in hooks that are jsut wrappers around boto3 API. That is the case of this method, we are justing calling boto3 API with the parameters provided. There is no real value added by this method. In you operator, instead of calling this hook method, you can call the boto3 API directly. Please look at other operators/hooks, you'll find plenty of examples -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
