vincbeck commented on code in PR #55506:
URL: https://github.com/apache/airflow/pull/55506#discussion_r2394850249
##########
providers/fab/src/airflow/providers/fab/www/views.py:
##########
@@ -70,8 +70,8 @@ def index(self):
token = get_auth_manager().generate_jwt(g.user)
response = make_response(redirect(f"{conf.get('api', 'base_url',
fallback='/')}", code=302))
- secure = bool(conf.get("api", "ssl_cert", fallback=""))
- response.set_cookie(COOKIE_NAME_JWT_TOKEN, token, secure=secure)
+ secure = request.scheme == "https" or bool(conf.get("api",
"ssl_cert", fallback=""))
+ response.set_cookie(COOKIE_NAME_JWT_TOKEN, token, secure=secure,
httponly=True)
Review Comment:
I handled both scenarios. I assumed this will be released in 3.2. Do you
think we should release it in 3.1? It is technically a bug fix but it is also a
big change so I think we should wait 3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
