gopidesupavan commented on PR #56270:
URL: https://github.com/apache/airflow/pull/56270#issuecomment-3364466708
> Let's remove the unrelated change from the tests or explain why it is
required.
sorry what i meant is , the relative_to function implementation changed.
in 0.3.0 its returning
<img width="617" height="155" alt="image"
src="https://github.com/user-attachments/assets/7accf611-52d0-4aae-8f1f-e825d2b115e3";
/>
in 0.2.6
<img width="671" height="182" alt="image"
src="https://github.com/user-attachments/assets/e2fcac0a-8856-4ea4-8c14-43153caeaf5f";
/>
earlier versions the implementation of relative_to function is in the
cloudpath:
https://github.com/fsspec/universal_pathlib/pull/405/files#diff-311a53e84d3cff9dd608444fabb9f22eace31a4f35cdd481083d1761296e41cdL63
but its removed from the cloud path instead it is now implemented in core with
slight modification that returns `_relative_base`
https://github.com/fsspec/universal_pathlib/blob/main/upath/core.py#L1074
So the test failing with the current implementation of `relative_to`:
<img width="1768" height="110" alt="image"
src="https://github.com/user-attachments/assets/9f42cf11-9a12-46dd-b22e-6646d1348af3";
/>
i could change the assertion from `assert o1.relative_to(o2) == o1 ` ->
`assert o1.relative_to(o2)` hope its fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
