Lee-W commented on code in PR #55110:
URL: https://github.com/apache/airflow/pull/55110#discussion_r2428225906
##########
providers/google/tests/unit/google/cloud/hooks/test_bigquery.py:
##########
@@ -673,11 +675,27 @@ def test_job_id_validity(self, mock_md5, test_dag_id,
expected_job_id):
job_id=None,
dag_id=test_dag_id,
task_id="test_job_id",
- logical_date=datetime(2020, 1, 23),
+ logical_date=None,
configuration=configuration,
+ run_after=datetime(2020, 1, 23),
)
assert job_id == expected_job_id
+ def test_get_run_after_or_logical_date(self):
+ import pendulum
Review Comment:
this can be moved to top level
##########
providers/google/tests/unit/google/cloud/operators/test_workflows.py:
##########
@@ -86,6 +89,41 @@ def test_execute(self, mock_hook, mock_object):
assert result == mock_object.to_dict.return_value
+ def test_execute_without_workflow_id(self):
+ import pendulum
+
+ from airflow.models.dagrun import DagRun
+
+ from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS
Review Comment:
These can be moved to top level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
