pierrejeambrun commented on code in PR #56030:
URL: https://github.com/apache/airflow/pull/56030#discussion_r2436731400
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py:
##########
@@ -220,6 +220,8 @@ def get_hitl_details(
to_replace={
"dag_id": TI.dag_id,
"run_id": TI.run_id,
+ "task_id": TI.task_id,
Review Comment:
I mean “ti_id” is part of the public API so we should use that now.
If we want to change it for “task_id” we can and mark the “ti_id” one as
deprecated; but there is no way to achieve that easily atm. (Because it is a
value of a query param that is deprecated, not the entire query param)
if it is too complicated we can keep things like this I suppose and set a
comment in the code only for deprecation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
