potiuk commented on issue #6595: [AIRFLOW-6002] Drop support for python 3.5
URL: https://github.com/apache/airflow/pull/6595#issuecomment-554800995
 
 
   And one more thing here @bolkedebruin  - for some of those scripts (static 
checks) we wanted to force always 3.5 version - no matter what you had setup as 
your current python version (simply because we wanted to run static checks 
consistently for all static checks. That's why in those scripts we "hard-coded" 
3.5 before any of the common scripts were loaded, to make sure that 
PYTHON_VERSION is set before any of the initialisation happens. I will have to 
add a common script to force PYTHON_VERSION but I think it's a bit easier to 
write:
   ```
   PYTHON_VERSION=3.6 
   ```
   rather than
   
   ```
   source ${ARIFLOW_SOURCES}/common/_force_python_version.sh
   ```
   I am reviewing the scripts now in my PR and will try to find some good and 
readable solution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to