Miretpl commented on code in PR #55832:
URL: https://github.com/apache/airflow/pull/55832#discussion_r2437471735


##########
chart/templates/statsd/statsd-serviceaccount.yaml:
##########
@@ -32,8 +32,8 @@ metadata:
     release: {{ .Release.Name }}
     chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
     heritage: {{ .Release.Service }}
-    {{- with .Values.labels }}
-      {{- toYaml . | nindent 4 }}
+    {{- if or (.Values.labels) (.Values.statsd.labels) }}

Review Comment:
   In functions or nested conditionals - yes. Regarding the occurrence in the 
chart, it is not consistent. In some places we have them, and in some we don't.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to