eladkal commented on code in PR #53182: URL: https://github.com/apache/airflow/pull/53182#discussion_r2390768737
########## providers/google/docs/operators/cloud/vertex_ai.rst: ########## @@ -756,6 +756,10 @@ Interacting with Ray on Vertex AI Cluster To create a Ray cluster you can use :class:`~airflow.providers.google.cloud.operators.vertex_ai.ray.CreateRayClusterOperator`. +Please note that you need to specify python_version and ray_version in :class:`~airflow.providers.google.cloud.operators.vertex_ai.ray.CreateRayClusterOperator`. +Currently supported versions of ray package in ray cluster are: 2.9.3, 2.33, 2.42. +For more information you can check: https://github.com/googleapis/python-aiplatform/blob/main/setup.py#L101 Review Comment: The package has doc it looks like they just don't document which ray version they support. Might worth asking them to do so? The sentence of ``` Currently supported versions of ray package in ray cluster are: 2.9.3, 2.33, 2.42. For more information you can check: https://github.com/googleapis/python-aiplatform/blob/main/setup.py#L101 ``` Should be something like: `To read more about compatible versions of Ray check the Google docs in <Link to upstream doc>` This avoids the need to update our docs for every change upstream library makes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
