ephraimbuddy commented on code in PR #54505:
URL: https://github.com/apache/airflow/pull/54505#discussion_r2429340890
##########
providers/amazon/tests/unit/amazon/aws/operators/test_datasync.py:
##########
@@ -217,9 +217,11 @@ def test_init_fails(self, mock_get_conn):
with pytest.raises(AirflowException):
self.set_up_operator(source_location_uri=None)
with pytest.raises(AirflowException):
- self.set_up_operator(destination_location_uri=None)
+ self.set_up_operator(destination_location_uri=None,
task_id="datasync_task2")
Review Comment:
The tests, all test different combination of args to the DataSyncOperator
that could raise error. The test were not working properly before since it was
raising the AirflowException which other exceptions were drived from. After
separating it, it started to fail on duplicatedidexception, which indicated an
error in the set_up_operator method. After I fixed the task_ids to have
different id, it started raising the right exception. I have removed this
change and instead fixed the set_up_operator method itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
