TyrellHaywood commented on code in PR #56371:
URL: https://github.com/apache/airflow/pull/56371#discussion_r2434335480
##########
providers/amazon/tests/unit/amazon/aws/hooks/test_sqs.py:
##########
@@ -127,12 +118,17 @@ def test_send_message_with_attributes(self, hook):
received = hook.get_conn().receive_message(QueueUrl=self.queue_url,
MessageAttributeNames=["All"])
assert "Messages" in received
message = received["Messages"][0]
- assert message["MessageAttributes"]["Author"]["StringValue"] ==
"test-user"
- assert message["MessageAttributes"]["Priority"]["StringValue"] == "1"
+ assert (
Review Comment:
I think combining them would look cleaner, but one thing I'm considering:
with separate assertions, if the test fails you immediately know which specific
attribute is wrong. With the combined assertion, you'd see the whole dict
comparison. Do you think that trade-off matters significantly here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
