ferruzzi commented on code in PR #56578:
URL: https://github.com/apache/airflow/pull/56578#discussion_r2430896953
##########
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/hooks/test_kubernetes.py:
##########
@@ -760,9 +760,11 @@ def test_check_kueue_deployment_running(self,
mock_get_deployment_status, mock_l
@mock.patch(HOOK_MODULE + ".KubernetesHook.log")
@mock.patch(HOOK_MODULE + ".KubernetesHook.get_deployment_status")
def test_check_kueue_deployment_raise_exception(self,
mock_get_deployment_status, mock_log):
- mock_get_deployment_status.side_effect = ValueError
+ mock_get_deployment_status.side_effect = ValueError(
+ "Exception occurred while checking for Deployment status."
+ )
- with pytest.raises(ValueError):
+ with pytest.raises(ValueError, match="Exception occurred while
checking for Deployment status."):
Review Comment:
This smells a little funny assigning the return value then asserting it...
plus this is disconnected from the actual code. what if someone changes the
actual error type or message, that won't be reflected here.
I don't have a solid suggestion, but this one feels off to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
