OmarFarooq908 commented on issue #56291:
URL: https://github.com/apache/airflow/issues/56291#issuecomment-3368643169

   Hi @Ferdinanddb and @HsiuChuanHsu,
   
   I was able to reproduce this issue and have created a fix for it. 
   
   The problem happens because in deferrable mode, the `launcher` attribute 
gets set during `execute()` but then when the trigger completes and calls 
`process_pod_deletion()`, the launcher is no longer available.
   
   I added some checks in the `process_pod_deletion()` and `on_kill()` methods 
to handle when the launcher isn't there. Instead of crashing, it now shows a 
warning message.
   
   I was able to reproduce the exact error you described. My fix prevents the 
crash and it still works normally when launcher is available.
   
   I've created PR #56399 with the fix: 
https://github.com/apache/airflow/pull/56399
   
   This is my first open source contribution, so please let me know if I need 
to change anything or if you have any questions about the approach I took.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to