sc250072 commented on code in PR #56305:
URL: https://github.com/apache/airflow/pull/56305#discussion_r2425467272
##########
providers/teradata/src/airflow/providers/teradata/hooks/teradata.py:
##########
@@ -195,12 +196,32 @@ def _get_conn_config_teradatasql(self) -> dict[str, Any]:
return conn_config
- def get_sqlalchemy_engine(self, engine_kwargs=None):
Review Comment:
It will fall back to this method and return the same URL from
[sqlalchemy_url](https://github.com/apache/airflow/blob/db4b534a29abe5a990d776b311f0dcb80631d65b/providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py#L319).
But any case,
I’ll re-add the function with a deprecation warning to preserve backward
compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
