ido177 opened a new pull request, #56245:
URL: https://github.com/apache/airflow/pull/56245
closes: #56143
---
At this moment, users have to specify git_username and git_token twice in
the git-sync secret, once for GIT_SYNC_* (v3) and once for GITSYNC_* (v4). This
is redundant and confusing.
```
---
apiVersion: v1
kind: Secret
metadata:
name: airflow-git-credentials
stringData:
GITSYNC_USERNAME: "git_username"
GITSYNC_PASSWORD: "git_token"
GIT_SYNC_USERNAME: "git_username"
GIT_SYNC_PASSWORD: "git_token"
```
This PR updates the Helm chart logic to choose the correct environment
variable set based on the git-sync image tag:
If the tag is < 4.0.0 - use GIT_SYNC_*
If the tag is >= 4.0.0 or latest - use GITSYNC_*
Example (after this change)
```
apiVersion: v1
kind: Secret
metadata:
name: airflow-git-credentials
stringData:
GITSYNC_USERNAME: "git_username"
GITSYNC_PASSWORD: "git_token"
```
Only the relevant variables need to be set, depending on the git-sync
version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
