FrankPortman opened a new issue, #56215:
URL: https://github.com/apache/airflow/issues/56215

   ### Apache Airflow version
   
   3.1.0
   
   ### If "Other Airflow 2 version" selected, which one?
   
   _No response_
   
   ### What happened?
   
   The way classname gets resolved has changed, breaking custom `deserialize` 
calls.
   
   Isolated the issue to these PRs:
   
   * 
https://github.com/apache/airflow/pull/52360/files#diff-5d7a43b9860e3c6d80d8feadce5ae76a3a56698fd8dff389fb6095c01153e74eR267
   * https://github.com/apache/airflow/pull/51059
   
   Which mentions `pydantic` only but has a `classname` --> `cls` change for 
custom deserializers bundled in the commentary. The `pydantic` specific naming 
of the PRs made this difficult to debug when looking at git history.
   
   The documentation also still shows comparing `classname` to `qualname(...)`, 
as well as `str` type hints for `classname`. This also made it difficult to 
debug when poring over changes for 3.1.0.
   
   ### What you think should happen instead?
   
   Release notes and documentation (including this example, which is basically 
the only example of registering serializers: 
https://airflow.apache.org/docs/apache-airflow/stable/authoring-and-scheduling/serializers.html)
 should be updated if behavior changes, and this should have been listed as a 
significant/breaking change in 3.1.0 release notes.
   
   
   
   ### How to reproduce
   
   Use registered custom serializers and follow the official documentation for 
the `deserialize` function.
   
   ### Operating System
   
   Any
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Astronomer
   
   ### Deployment details
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to