o-nikolas commented on code in PR #55797:
URL: https://github.com/apache/airflow/pull/55797#discussion_r2382954148
##########
dev/stats/explore_pr_candidates.ipynb:
##########
Review Comment:
Why is this file being changed?
##########
providers/amazon/tests/unit/amazon/aws/operators/test_notebook.ipynb:
##########
Review Comment:
Same with this one?
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -720,7 +724,16 @@ def _adopt_completed_pods(self, kube_client:
client.CoreV1Api) -> None:
continue
ti_id = annotations_to_key(pod.metadata.annotations)
- self.running.add(ti_id)
+ self.completed.add(
Review Comment:
Why not just change state here instead of creating a new set and looping
over them elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
