amoghrajesh opened a new pull request, #56702:
URL: https://github.com/apache/airflow/pull/56702
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Databricks provider tests were failing with `ModuleNotFoundError: No module
named 'flask_appbuilder'` when the fab provider was not installed, which is the
default in Airflow 3.0+ and Python 3.13+.
This was introduced by commit 5a2e95af9c2a939dda5a005f081845e2a92a5717,
which removed the pytest ignores for flask-appbuilder in various tests.
The `databricks_workflow.py` plugin had unconditional imports of `flask` and
`flask_appbuilder` at module level, even though the repair functionality using
these imports is only for Airflow 2.x and is explicitly disabled for Airflow
3.0+.
**Fix:**
- Moved `flask` and `flask_appbuilder` imports into the `if not
AIRFLOW_V_3_0_PLUS:` conditional block
- Moved `_repair_task()` function and `RepairDatabricksTasks` class into the
same conditional block
This follows the same pattern used in the edge3 provider plugin. The repair
functionality still works in Airflow 2.x, and Databricks operators can now be
imported in Airflow 3.0+ without the fab provider.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
