vincbeck commented on PR #55954:
URL: https://github.com/apache/airflow/pull/55954#issuecomment-3347060171

   > And I believe it should be entirely removed in FAB. I am not sure why it's 
there to be honest. @vincbeck explained it's used for some endpoints - but I 
believe this should all be done with fast_api, because we are fully controlling 
the endpoints and there is no particular reasons we should be using connexion 
for it - so I think eventually fab provider should not have connexion as 
dependency at all.
   
   The Fab provider API (e.g. list user, role, permissions etc APIs) still uses 
connexion. We did not migrate this API with fastapi and we keep using 
connexion, the way it works is, in the main Airflow fastapi application, we use 
`WSGIMiddleware` to "embed" the Flask application into a Fastapi application.
   
   However, I did not realize we had to upgrade `connexion[flask]` before 
upgrading `sqlalchemy`. I am not sure how big is the effort. I'll look into it.
   
   > If we do that - FAB should still, however have sqla 2 + sqla 1 support - 
until it supports Airflow 3.0 and 3.1 (so we cannot add sqlalchemy>2 in FAB - 
only in airflow-core
   
   Not sure I understand this. Can you explain more? Version of fab provider in 
main is only compatible with AF3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to