github-advanced-security[bot] commented on code in PR #56624:
URL: https://github.com/apache/airflow/pull/56624#discussion_r2429901506
##########
providers/keycloak/src/airflow/providers/keycloak/auth_manager/keycloak_auth_manager.py:
##########
@@ -270,6 +270,62 @@
realm_name=realm,
)
+ def _refresh_access_token(self, user: KeycloakAuthManagerUser) -> bool:
+ """
+ Refresh expired access token using refresh token.
+
+ Args:
+ user: The user whose token needs to be refreshed
+
+ Returns:
+ bool: True if refresh succeeded, False otherwise
+ """
+ if not user.refresh_token:
+ log.warning("No refresh token available for user %s",
user.get_id())
+ return False
+
+ realm = conf.get(CONF_SECTION_NAME, CONF_REALM_KEY)
+ server_url = conf.get(CONF_SECTION_NAME, CONF_SERVER_URL_KEY)
+ client_id = conf.get(CONF_SECTION_NAME, CONF_CLIENT_ID_KEY)
+ client_secret = conf.get(CONF_SECTION_NAME, CONF_CLIENT_SECRET_KEY)
+
+ token_url = self._get_token_url(server_url, realm)
+
+ try:
+ response = requests.post(
+ token_url,
+ data={
+ "grant_type": "refresh_token",
+ "refresh_token": user.refresh_token,
+ "client_id": client_id,
+ "client_secret": client_secret,
+ },
+ timeout=10,
+ )
+
+ if response.status_code == 200:
+ tokens = response.json()
+
+ user.access_token = tokens["access_token"]
+
+ if "refresh_token" in tokens:
+ user.refresh_token = tokens["refresh_token"]
+
+ log.info("Successfully refreshed access token for user %s",
user.get_id())
+ return True
+ else:
+ log.error(
+ "Failed to refresh token for user %s: %s - %s",
+ user.get_id(),
+ response.status_code,
+ response.text,
Review Comment:
## Clear-text logging of sensitive information
This expression logs [sensitive data (secret)](1) as clear text.
This expression logs [sensitive data (secret)](2) as clear text.
[Show more
details](https://github.com/apache/airflow/security/code-scanning/536)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
