HsiuChuanHsu commented on PR #56402: URL: https://github.com/apache/airflow/pull/56402#issuecomment-3387542963
> after this change, this line is still needed? I think it is two distinct behaviors related to termination_grace_period. The `param: termination_grace_period` being added is specific to the Kubernetes Pod Operator (KPO). The `on_kill()` method you pointed out does not automatically inherit the KPO's `termination_grace_period` setting. So to ensure the behavior of `on_kill()` remains same behaviors as the KPO's setting, I think we should keep the `kwargs.update` call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
