potiuk commented on PR #55894: URL: https://github.com/apache/airflow/pull/55894#issuecomment-3410069438
> @potiuk @uranusjr good, would wrapped `DagBag` carefully applied in those 3 cases be considered improvement over current state and also useful extension of dag command? I think @uranusjr point about "no cleanup at all" is a good one. The try/finally gives you false sense of "being properly cleaned up". So I'd would even say we might simply add the path and not clean it deliberately (maybe a helper method of some sorts). And I think it should be plain obvious in that code that: 1) the lack of cleanup is not a misteke but deliberte choice 2) that it is only used because of Ephemeral interpreter that is going away soon. Maybe some `addBundlePathForEphemeralInterpreter` as a helper method (yes - I am bad in naming). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
