amoghrajesh commented on code in PR #55111:
URL: https://github.com/apache/airflow/pull/55111#discussion_r2431319734
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -1076,8 +1079,8 @@ def _serialize_params_dict(cls, params: ParamsDict |
dict) -> list[tuple[str, di
return serialized_params
@classmethod
- def _deserialize_params_dict(cls, encoded_params: list[tuple[str, dict]])
-> ParamsDict:
- """Deserialize a DAG's Params dict."""
+ def _deserialize_params_dict(cls, encoded_params: list[tuple[str, dict]])
-> SerializedParamsDict:
+ """Deserialize a DAG's Params dict using server-side classes."""
Review Comment:
```suggestion
"""Deserialize a DAG's Params dict using server-side classes:
SerializedParam and SerializedParamsDict"""
```
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -1028,16 +1029,14 @@ def _serialize_param(cls, param: Param):
}
@classmethod
- def _deserialize_param(cls, param_dict: dict):
+ def _deserialize_param(cls, param_dict: dict) -> SerializedParam:
"""
- Workaround to serialize Param on older versions.
+ Deserialize Param using server-side class to avoid SDK coupling.
Review Comment:
```suggestion
Deserialize Param using server-side class: SerializedParam to avoid
SDK coupling.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
