amoghrajesh commented on code in PR #56811:
URL: https://github.com/apache/airflow/pull/56811#discussion_r2442044280
##########
airflow-e2e-tests/tests/airflow_e2e_tests/remote_log_tests/test_remote_logging.py:
##########
@@ -27,6 +28,9 @@
class TestRemoteLogging:
airflow_client = AirflowClient()
dag_id = "example_xcom_test"
+ task_count = 6
+ retry_delay_seconds = 1
Review Comment:
```suggestion
retry_interval_in_seconds = 1
```
##########
airflow-e2e-tests/tests/airflow_e2e_tests/remote_log_tests/test_remote_logging.py:
##########
@@ -72,9 +76,25 @@ def test_remote_logging_s3(self):
bucket_name = "test-airflow-logs"
response = s3_client.list_objects_v2(Bucket=bucket_name)
+ # Wait for logs to be available in S3
+ for _ in range(self.max_retries):
+ response = s3_client.list_objects_v2(Bucket=bucket_name)
+ contents = response.get("Contents", [])
+ if len(contents) >= self.task_count:
+ break
+
+ print(f"Expected at least {self.task_count} log files, found
{len(contents)}. Retrying...")
+ time.sleep(self.retry_delay_seconds)
Review Comment:
```suggestion
time.sleep(self.retry_interval_in_seconds)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
