1fanwang commented on PR #56272: URL: https://github.com/apache/airflow/pull/56272#issuecomment-3393995232
> Sorry, the maintainer community is a bit distracted as of many people are on travel to https://airflowsummit.org/ - but no pressure the next release is a bit to go so the change can wait a moment until merge. I am personally no expert in this area and would like also other opinions on this. > > Meanwhile if this is a critical function for you to ensure this is coming, can you also please add a pytest for this to ensure that some level of change will not (by accident even) revert or change behavior if you need this? Thanks for the feedback! No worries at all about the timing - I completely understand everyone is busy with Airflow Summit - I was actually there as a speaker as well and really enjoyed meeting up with folks. I've added a test for this change in test_scheduler_job.py - specifically test_dag_timeout_notifies_with_timed_out_msg which verifies that notify_dagrun_state_changed() is called with msg="timed_out" when a DAG run times out. This should ensure the behavior is preserved going forward. The test mocks the listener manager and verifies that the on_dag_run_failed hook receives the correct message parameter. It's a minimal test focused on the specific change. I'm happy to wait for additional reviews and feedback when folks are back from the summit. This is important for our use case (proper context propagation to failure callbacks/listeners), but there's no immediate rush on our end. Thanks again for taking the time to review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
