shahar1 commented on code in PR #55874:
URL: https://github.com/apache/airflow/pull/55874#discussion_r2403950594
##########
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -246,6 +253,32 @@ def get_oauth_token(
token = response.json()["access_token"]
return token
+ def get_azure_oauth_token(self, azure_conn_id: str) -> str:
+ """
+ Generate OAuth access token using Azure connection id.
+
+ This uses AzureBaseHook to retrieve the token.
+ """
Review Comment:
Could you please add docstring for input (`azure_conn_id`) + output (what it
returns), and write some tests for this method? (the exceptions in particular)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
