zanecodes commented on code in PR #55820:
URL: https://github.com/apache/airflow/pull/55820#discussion_r2411041337


##########
chart/values.yaml:
##########
@@ -2853,9 +2853,13 @@ cleanup:
   successfulJobsHistoryLimit: ~
 
 # Configuration for postgresql subchart
-# Not recommended for production
+# Uses bitnamilegacy images to avoid Bitnami licensing restrictions
+# Not recommended for production - use external database instead
 postgresql:
   enabled: true
+  image:
+    repository: postgres
+    tag: "13"

Review Comment:
   The Airflow Helm chart [currently uses version 
`13.2.24`](https://github.com/apache/airflow/blob/helm-chart/1.18.0/chart/Chart.yaml#L37)
 of the Bitnami PostgreSQL Helm chart, but this **does not** correspond to 
version 13 of PostgreSQL. Version `13.2.24` of the Bitnami PostgreSQL Helm 
chart [uses the tag `16.1.0-debian-11-r15` of the `bitnami/postgresql` Docker 
image](https://github.com/bitnami/charts/blob/postgresql/13.2.24/bitnami/postgresql/values.yaml#L101).
   
   This tag [is present in the `bitnamilegacy` 
repository](https://hub.docker.com/layers/bitnamilegacy/postgresql/16.1.0-debian-11-r15/images/sha256-9d1334877f8ca27be121f122dea7e22d3c3df05dd0c984042b09d5ffdd37623b),
 so I think the correct fix is to update the `repository` value above to 
`bitnamilegacy/postgresql`, and either omit the `tag` or pin it to 
`16.1.0-debian-11-r15`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to